summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-03-13Remove no-op link from submodule entriesLukas Fleischer
Instead of linking to the current page ("href='#'"), do not add a link to a submodule entry at all if the module-link setting is not used. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-03-13filters: Add sample gentoo scriptJason A. Donenfeld
2015-03-09cgit: remember to set up env vars before empty clone pathJason A. Donenfeld
2015-03-09ui-shared: currenturl should take into account leading slashJason A. Donenfeld
2015-03-09html: avoid using a plain integer as a NULL pointerJohn Keeping
Sparse complains about this table because we use the integer zero as the NULL pointer. Use this as an opportunity to reformat the table so that it always contains 8 elements per row, making it easier to see which values are being set and which are not. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09cache: don't use an integer as a NULL pointerJohn Keeping
Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-shared: don't use an integer as a NULL pointerJohn Keeping
Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-shared: avoid initializing static variable to zeroJohn Keeping
Sparse complains that we are using a plain integer as a NULL pointer here, but in fact we do not have to specify a value for this variable at all since it has static storage duration and thus will be initialized to NULL by the compiler. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-stats: make cgit_period definitions 'static const'John Keeping
These definitions should not be modified (and never are) so we can move them to .rodata. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-shared: make cgit_doctype 'static'John Keeping
This is not used outside this file and is not declared. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-repolist: make sortcolumn definitions 'static const'John Keeping
These are not used outside this file and are not declared; they are also never modified. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09ui-log: make some variables 'static'John Keeping
These are not used outside this file and are not declared. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09shared: make some variables 'static'John Keeping
These are not used outside this file and are not declared. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09scan-tree: make some variables 'static'John Keeping
These are not used outside this file and are not declared. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09Avoid signed bitfieldsJohn Keeping
Bitfields are only defined for unsigned types. Detected by sparse. Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09Avoid non-ANSI function declarationsJohn Keeping
Sparse says things like: warning: non-ANSI function declaration of function 'calc_ttl' Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-09Makefile: add a target to run CGit through sparseJohn Keeping
Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-07git: update to v2.3.2Christian Hesse
Update to git version v2.3.2, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2015-03-05Bump versionJason A. Donenfeld
2015-03-05Drop return value from parse_user()Lukas Fleischer
In commit 936295c (Simplify commit and tag parsing, 2015-03-03), the commit and tag parsing code was refactored. This broke tag messages in ui-tag since the line after the tagger header was erroneously skipped. Rework parse_user() and skip the line manually outside parse_user(). Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-03-05Remove leading newline characters from tag messagesLukas Fleischer
Fixes a regression introduced in commit 936295c (Simplify commit and tag parsing, 2015-03-03). Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-03-05simple-authentication.lua: tie secure cookies to field namesJason A. Donenfeld
2015-03-05cgit: show clone URLs for empty repoJason A. Donenfeld
2015-03-03cache: use F_SETLK to avoid stale lock filesJohn Keeping
If CGit is killed while it holds a lock on a cache slot (for example because it is taking too long to generate a page), the lock file will be left in place. This prevents any future attempt to use the same slot since it will fail to exclusively create the lock file. Since CGit is the only program that should be manipulating lock files, we can use advisory locking to detect whether another process is actually using the lock file or if it is now stale. I have confirmed that this works on Linux by setting a short TTL in a custom cgitrc and running the following with CGit patched to print a message to stderr if the fcntl(2) fails: $ export CGIT_CONFIG=$PWD/cgitrc $ export QUERY_STRING=url=cgit/tree/ui-shared.c $ ./cgit | grep -v -e '^<div class=.footer.>' \ -e '^Last-Modified: ' \ -e ^'Expires: ' >expect $ seq 50000 | dd bs=8192 | parallel -j200 "diff -u expect <(./cgit | grep -v -e '^<div class=.footer.>' \ -e '^Last-Modified: ' \ -e ^'Expires: ') || echo BAD" This printed the fail message several times without ever printing "BAD". Signed-off-by: John Keeping <john@keeping.me.uk>
2015-03-03Make root handling sane again.Jason A. Donenfeld
2015-03-03ui-shared: Add current url helper function.Jason A. Donenfeld
2015-03-03ui-shared: keep filter repolist page in paginationJason A. Donenfeld
2015-03-03ui-repolist: use ctx.qry.url instead of rooturl, in case we're filteringJason A. Donenfeld
2015-03-03ui-repolist: use correct owner query linkJason A. Donenfeld
2015-03-03Simplify commit and tag parsingLukas Fleischer
* Use skip_prefix to avoid magic numbers in the code. * Use xcalloc() instead of xmalloc(), followed by manual initialization. * Split out line splitting. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-03-03git: update to v2.3.1Christian Hesse
Update to git version v2.3.1, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2015-02-15Bump verisonJason A. Donenfeld
2015-02-15shrink cgit.png file sizeChristian Hesse
Ran optipng against cgit.png, which shrank file size by more than eight percent. The image (including protocol overhead) should fit into a single network packet now. Optipng optimizes filters and compression. The actual pixel results are not altered. Signed-off-by: Christian Hesse <mail@eworm.de>
2015-02-09ui-clone.c: Fix off-by-one error in pack pathJason A. Donenfeld
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
2015-02-09ui-clone.c: Fix path checkLukas Fleischer
The starts_with() check was broken in two ways: For one thing, the parameters were passed in the wrong order, for another thing, starts_with() returns 1 if the string starts with the prefix (not 0). Note that this bug existed since commit 02a545e (Add support for cloning over http, 2008-08-06) but only pops in in corner cases. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-02-08git: update for v2.3.0Christian Hesse
* sort_string_list(): rename to string_list_sort() (upstream commit 3383e199) * update read_tree_recursive callback to pass strbuf as base (upstream commit 6a0b0b6d) Signed-off-by: Christian Hesse <mail@eworm.de>
2015-02-05ui-shared.c: Refactor add_clone_urls()Lukas Fleischer
Make use of strbuf_split_str() and strbuf lists to split clone URLs. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-01-29Add repo.hide and repo.ignoreLukas Fleischer
These options can be used to hide a repository from the index or completely ignore a repository, respectively. They are particularly useful when used in combination with scan-path. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-01-28Add Etags for snapshotsJanus
2015-01-19tag: reference with "h" instead of "id"John Keeping
When clicking on "log" from a tag we end up showing the log of whatever branch we used to reach the tag. If the tag doesn't point onto a branch then the tagged commit won't appear in this output. By linking to tags with the head parameter instead of the "id" parameter the log link will show the log of the tag. This is clearly desirable when the tag has been reached from the refs UI and changing the behaviour for tag decorations makes them match branch decorations where log -> decoration -> log shows the log of the decoration. Reported-by: Ferry Huberts <mailings@hupie.com> Signed-off-by: John Keeping <john@keeping.me.uk>
2015-01-15Return proper HTTP response when accessing info/Lukas Fleischer
Currently, when a user directly accesses the info command of a repository, we exit cgit without printing anything to stdout, bringing up error messages like "502 Bad Gateway" or "An error occurred while reading CGI reply (no response received)". Instead of bailing out, at least print the HTTP headers, including a reasonable error message. Reported-by: Janus Troelsen Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2015-01-13git: update to v2.2.2Christian Hesse
Update to git version v2.2.2, no changes required. Signed-off-by: Christian Hesse <mail@eworm.de>
2014-12-30ui-diff: don't link to single file diff statJohn Keeping
Seeing the diff stat for a single file is pretty useless, so reset the diff type before generating the links to individual files in the diff stat so that the links will show a useful diff. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> Signed-off-by: John Keeping <john@keeping.me.uk>
2014-12-28ui-patch: match git-format-patch(1) outputJohn Keeping
Using (DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_PATCH) causes Git to emit a "---" line between the commit message and the body of the patch, which fixes a regression introduced in commit 455b598 (ui-patch.c: Use log_tree_commit() to generate diffs, 2013-08-20), prior to which we inserted the "---" line ourselves. DIFF_FORMAT_SUMMARY is added so that we match the output of git-format-patch(1) without the "-p" option. Signed-off-by: John Keeping <john@keeping.me.uk>
2014-12-28t0108: modernize styleJohn Keeping
* &&-chaining * use test_cmp instead of cmp * use strip_headers instead of knowing how many lines there will be Signed-off-by: John Keeping <john@keeping.me.uk>
2014-12-24Revert "git: use xz compressed archive for download"Jason A. Donenfeld
This reverts commit a87c9d8a9779eab0499efd3c44e090a28c7d1cdf. We want to make OpenBSD people happy.
2014-12-24Use split_ident_line() in parse_user()Lukas Fleischer
Use Git's built-in ident line splitting algorithm instead of reimplementing it. This does not only simplify the code but also makes sure that cgit is consistent with Git when it comes to author parsing. Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
2014-12-23footer: link back to cgit home pageJason A. Donenfeld
The footer has always been overrideable using the footer= in cgitrc, so this won't anger anybody who cares about their footer.
2014-12-23ui-shared: show absolute time in tooltip for relative datesJohn Keeping
Signed-off-by: John Keeping <john@keeping.me.uk>
2014-12-23git: use xz compressed archive for downloadChristian Hesse
generated by cgit (git 2.30.0) at 2024-12-24 02:55:06 +0000